PPPoE buglet...

[Christophe Prevotaux]

Yes please fix it. 

On Wed, 17 Mar 2004 11:52:53 +0000
David Malone <dwmalone at maths.tcd.ie> wrote:

> I spent a while trying to get PPPoE going through a Netopia smart
> modem last night. To cut a long story short, the values for
> PTT_RELAY_SID in src/sys/netgraph/ng_pppoe.h are wrong (at least
> when compared with tcpdump, linux and the RFC). We have:
> 
> #if BYTE_ORDER == BIG_ENDIAN
> #define PTT_RELAY_SID   (0x0106)
> #else
> #define PTT_RELAY_SID   (0x0601)
> #endif
> 
> but we should have:
> 
> #if BYTE_ORDER == BIG_ENDIAN
> #define PTT_RELAY_SID   (0x0110)
> #else
> #define PTT_RELAY_SID   (0x1001)
> #endif
> 
> Anyone object to my fixing it? The only thing I can think of that
> it might break would be people using ng_pppoe as a PPPoE relay with
> only ng_pppoe PPPoE clients.
> 

--
===============================================================
Christophe Prevotaux      Email: c.prevotaux at hexanet.fr
HEXANET SARL                URL: http://www.hexanet.fr/
Z.A.C Les Charmilles        Tel: +33 (0)3 26 79 30 05 
3 Allée Thierry Sabine   Direct: +33 (0)3 26 61 77 72 
BP202                       Fax: +33 (0)3 26 79 30 06
51686 Reims Cedex 2 		                   
FRANCE                   HEXANET Network Operation Center             
===============================================================