[Bug 250248] 12.2-RC2 kernel reboots with hw.acpi.debug=1 after a warm reboot.

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250248

--- Comment #12 from Alexander Motin <mav at FreeBSD.org> ---
About the first patch adding shutdown handling I think it is an overkill for
workaround and wrong approach in general, since there is no reason to detach
the device on shutdown.  It is designed to flush some caches and do alike
things, and I know only one kind of devices detaching on shutdown -- USB,
though I don't know why Hans done it that way.

The second patch moving enabling UNSOL looks better to me, since I don't see
what good for us could those message be before we even probe the codecs, not
mentioning attaching them.  Theoretically, if we ever implement codec hot-plug
(for which I've never had a hardware), it would be required to better handle
UNSOL events during the CODEC probe, since it may happen during run time. 
Meanwhile if this patch works -- great, but generally it looks like a partial
case to me, since hdac_unsolq_flush() already checks for sc->codecs[cad].dev to
be NULL, that is assigned the last by the probe loop inside hdac_attach2().  So
it may just affect some timings, not really fix the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.