mixer_info modify_counter

Hans Petter Selasky hps at selasky.org
Sun Jul 22 19:25:51 UTC 2018


On 07/22/18 20:08, Ali Abdallah wrote:
> Hello,
> 
> Any reason why the modify_counter bit of mixer_info is not incremented when
> the mixer gets changed?
> 
>>From  sys/dev/sound/pcm/mixer.c:70
> /**
>    * Counter is incremented when applications change any of this
>    * mixer's controls.  A change in value indicates that persistent
>    * mixer applications should update their displays.
>    */
> 
> But reading the code, it is clear that this is not the case, and the
> counter remains 0. It is enough to call m->modify_counter++ in mixer_set on
> line 327 for example to make persistent mixer applications work correctly.
> Currently they have to poll for all mixer controls, even if no changes were
> made to the mixer.
> 

Hi,

Can you create a PR and add a patch?

--HPS



More information about the freebsd-multimedia mailing list