maintainer-feedback requested: [Bug 234230] [PATCH] multimedia/vlc3: Fix plugin cache broken after issuing strip(1) on every plugin

[bugzilla-noreply at freebsd.org]

Bugzilla Automation <bugzilla at FreeBSD.org> has asked freebsd-multimedia mailing
list <multimedia at FreeBSD.org> for maintainer-feedback:
Bug 234230: [PATCH] multimedia/vlc3: Fix plugin cache broken after issuing
strip(1) on every plugin
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234230



--- Description ---
At the end of port staging Makefile issues strip(1) cmd on every plugin
bundled.
That leads to stalled content of plugin cache (plugins.dat) and results in a
lot of warnings [1] at the start of vlc and sometimes causes startup crashes
[2] e.g. when gtk2 widgets are enabled with qt5ct.

Fix it with extra run of vlc-cache-gen right after the plugins have been
stripped.

[1]. vlc warnings:

$ vlc
VLC media player 3.0.4 Vetinari (revision 3.0.4-0-gf615db6332)
[0000000800af0060] main libvlc error: stale plugins cache: modified
/usr/local/lib/vlc/plugins/mux/libmux_ps_plugin.so
[0000000800af0060] main libvlc error: stale plugins cache: modified
/usr/local/lib/vlc/plugins/mux/libmux_ogg_plugin.so
[0000000800af0060] main libvlc error: stale plugins cache: modified
/usr/local/lib/vlc/plugins/mux/libmux_wav_plugin.so

[2]. vlc crash:

[0000000800acd060] main libvlc: Running vlc with the default interface. Use
'cvlc' to use vlc without interface.
qt5ct: using qt5ct plugin

(<unknown>:89888): Gtk-ERROR **: 23:30:11.352: GTK+ 2.x symbols detected. Using
GTK+ 2.x and GTK+ 3 in the same process is not supported
zsh: trace trap (core dumped)  vlc