[Bug 217051] [PATCH] multimedia/vlc: Build in C++11 mode by default

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sun Feb 12 21:47:58 UTC 2017


            Bug ID: 217051
           Summary: [PATCH] multimedia/vlc: Build in C++11 mode by default
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: multimedia at FreeBSD.org
          Reporter: rakuco at FreeBSD.org
                CC: multimedia at FreeBSD.org, riggs at FreeBSD.org
            Blocks: 216797
 Attachment #179920 maintainer-approval?(multimedia at FreeBSD.org)
          Keywords: patch
             Flags: maintainer-feedback?(multimedia at FreeBSD.org)
                CC: multimedia at FreeBSD.org

Created attachment 179920
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=179920&action=edit
Proposed patch

This is in preparation for the Qt 5.6.2 -> 5.7.1 update (bug 216797): Qt 5.7
requires C++11 support.

VLC 2.2.4 has issues building in C++11 mode, so incorporate a few upstream
commits to make things work, and adjust the atomics-related patches landed in
ports r416225, as including <atomic> only with libc++ >= 3.8.0 leaves out
FreeBSD 10.3. include/vlc_atomic.h is now closer to its git (post-2.2.4)
version, in that we now have 3 possible conditions:
1. The header is included in C11 mode, in which case <stdatomic.h> is included.
2. The header is included by C code but we're not building in C11 mode, in
which case some shims are defined.
3. The header is included by C++ code, so we can assume C++11 and just include

It will likely be possible to drop the changes once a new VLC version is
released, as upstream has since started requiring C+11 and passes the
appropriate flags to the compiler.

Referenced Bugs:

[Bug 216797] [exp-run] update Qt to 5.7.1, move Qt4 binaries and rename ports
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

More information about the freebsd-multimedia mailing list