Update mp4v2 to version 3.0.1.1
Herbert J. Skuhra
herbert at mailbox.org
Wed Sep 21 12:09:22 UTC 2016
Kevin Oberman skrev:
>
> I am just submitted a PR,
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212785 to update mp4v2 to
> 3.0.1.1 and change the source to github.
>
> First port I've submitted in about a decade, so the submission format may
> not be right. Please point out everything I did wrong.
I've downloaded the patch and applied it with 'svnlite patch'.
Now 'make patch' fails because patch-GNUmakefile.in does not apply
cleanly. If I remove the patch or apply it manually 'make check-plist'
fails:
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/libmp4v2.so.1
Error: Orphaned: lib/libmp4v2.so.1.9.1
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: lib/libmp4v2.so.3
Error: Missing: lib/libmp4v2.so.3.0.1
===> Error: Plist issues found.
> In the comments I included a list of ports needing a PORT_REVISION bump.
Are you sure that this is sufficient? Do these ports still build
afterwards? I guess not. e.g. faac requires a patch to build against
mp4v2 2.0.0:
<https://git.archlinux.org/svntogit/packages.git/tree/trunk/mp4v2-2.0.0.patch?h=packages/faac>
And why do you choose version 3.0.0.1 and not 2.0.0? Version 3.x is
obviously not official yet: The configure script reports:
configure:
-->
--> Configuring MP4v2 2.0.0
-->
I've checked some Linux Distributions (Debian, Arch, Gentoo, etc.) and
they all ship 2.0.0.
PBKAC or have you submitted the wrong/an untested patch?
--
Herbert
More information about the freebsd-multimedia
mailing list