[Bug 207547] [exp-run] Update ffmpeg to 3.2

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Dec 5 00:01:39 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207547

--- Comment #51 from Jan Beich (mail not working) <jbeich at FreeBSD.org> ---
Comment on attachment 177651
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=177651
svn diff to ffmpeg 3.2.1

> -USES=		compiler:c11 cpe gmake perl5 pkgconfig tar:bzip2 shebangfix
> +USES=		compiler cpe gmake perl5 pkgconfig tar:bzip2 shebangfix

What's the rationale for backing out ports r425640?

> -OPTIONS_DEFINE= AACPLUS ALSA AMR_NB AMR_WB ASS BS2B CACA CDIO CELT DC1394 \
> +OPTIONS_DEFINE= ALSA AMR_NB AMR_WB ASS BS2B CACA CDIO CELT CHROMAPRINT DC1394 \

Did you actually review upstream changes to configure during updates? One of
the following already has a port:

    --enable-libebur128      enable libebur128 for EBU R128 measurement,
                             needed for loudnorm filter [no]
    --enable-libopenmpt      enable decoding tracked files via libopenmpt [no]

> +	@${REINPLACE_CMD} -E \
> +		-e 's|#include <SDL|#include <SDL2/SDL|' \
> +		${WRKSRC}/ffplay.c \
> +		${WRKSRC}/libavdevice/opengl_enc.c \
> +		${WRKSRC}/libavdevice/sdl2.c

What's the rationale for keeping this cruft? "sdl2-config --cflags" already
includes path to where the correct SDL.h is located.

> +-                              sizeof(rtsp_st->sdp_ip),
[...]
>  +                        sizeof(rtsp_st->sdp_ip),

Nop change. Rebase to avoid + line by adjusting whitespace to be consistent
with the rest of the file.

> +--include $(SRC_PATH)/tests/checkasm/$(ARCH)/Makefile
> ++-include $(SRC_PATH)/tests/checkasm/$(FFMPEG_ARCH)/Makefile

Patching source to work around Mk/bsd.port.mk bug doesn't make sense. Define
NOPRECIOUSMAKEVARS=1 then drop all $(FFMPEG_ARCH) hacks.

> +%%OPENCL%%include/libavutil/opencl.h
>  include/libavcodec/avcodec.h

Sort as if %%FOO%% lines were all expanded to "" i.e., put %%OPENCL%% to where
it was.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the freebsd-multimedia mailing list