[review/test] multimedia/vlc: various fixes

[Tijl Coosemans]

Hi,

Please check out the attached patch for multimedia/vlc.  It contains the
following changes:

- Remove libproxy dependency.  I cannot find any references to it.
- Add libidn dependency.  It is always picked up when detected by
  configure.
- Add libxml2 dependency (USE_GNOME=libxml2).  It's actually an optional
  dependency but it is used by several other plugins.
- Replace OSVERSION+clang tests with USES=compiler:c11.
- Replace post-patch command with USES=pathfix.
- Add some more --enable-* flags to CONFIGURE_ARGS to make sure configure
  doesn't silently ignore problems with dependencies.
- Add some more --disable-* flags to CONFIGURE_ARGS to make sure
  configure doesn't auto-enable them.
- Specify the correct location of KDE Solid files in CONFIGURE_ARGS.
  ("Play with VLC" option when you insert a CD/DVD.)
- Add ac_cv_search_pthread_rwlock_init=-pthread to CONFIGURE_ARGS to
  override the test for libpthread.  It detects pthread_rwlock_init in
  our libc and assumes no threading library is needed, but libc doesn't
  have a real pthread implementation.
- Add the gnutls3 include directory to CPPFLAGS before LOCALBASE/include
  which may contain gnutls2 headers.
- Rename some options so more descriptions from bsd.options.desc.mk can
  be used.
- Add OPTIMIZED_CFLAGS to OPTIONS_DEFAULT.  Remove custom CFLAGS so this
  option only controls the "optimizations" configure option which is
  enabled by default by upstream.
- Remove REALAUDIO from OPTIONS_DEFAULT.  Old codec.
- Remove SDL from OPTIONS_DEFAULT.  This is an alternative way to render
  video.  The X11 option is better for this.
- Remove SKINS from OPTIONS_DEFAULT.
- Remove X264 from OPTIONS_DEFAULT.  It's an encoder, not a decoder and
  vlc is typically used as a player not as a video server.
- Remove SERVER_ONLY and NO_DVD options.  Their implementation doesn't
  work with modern options framework.
- Add a patch to fix some issues in the configure script, e.g. don't add
  -L/usr/local/lib to LDFLAGS.  This ends up in the wrong place on the
  linker command line causing installed vlc libraries to be linked in
  instead of freshly built ones.
- With patched configure some options like A52 need include/library
  search paths now.
- Some options have pkgconfig files now so remove include/library search
  paths where possible.
- Separate KATE option from OGG.
- Use option helpers for LIBRSVG2, LUA, OGG, QT4, SDL, V4L and X11.
- Implement NCURSES option with USES=ncurses.
- Add VDPAU option.
- Drop perl5 dependency.
- Drop old hacks like -fPIC, -I${WRKSRC}/include, LIBS="-lc", PTHREAD_LIBS.
- Add missing dependencies to SKINS option (libminizip, xorg)
- Patch the right file with WITH_CDROM_DEVICE and WITH_DVD_DEVICE.
- Only use auto-plist for the plugins directory.  Use regular pkg-plist,
  PORTDATA and PORTDOCS for everything else.  This is a lot simpler and
  makes it easier to detect library version changes.
- Delete some unneeded patches.

Redports test with all options enabled:
https://redports.org/buildarchive/20140601173701-19671/
https://redports.org/buildarchive/20140601181106-57163/
(FreeBSD 8.4 is still broken for some combinations of options due to a
bug in rtld there.)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vlc.patch
Type: text/x-patch
Size: 39685 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-multimedia/attachments/20140601/56047c1a/attachment.bin>