vlc-2.1.0.4 fails with libssh2 enabled

[Kevin Oberman]

On Mon, Oct 28, 2013 at 9:56 AM, William Grzybowski <william88 at gmail.com>wrote:

> It looks like it is an openssl problem.
> Have you tried installing the openssl package from ports?
>
> William,

Thanks for the very quick response!

I had not, but I just gave it a try and it allows vlc to configure, build,
and run. But this is not the right solution. Makefile does not have a
direct dependency on openssl at all, only libgcrypt and libssh2. Since both
are happy with the base openssl, vlc should build just fine!

In fact, after building vlc with openssl, it still does not use it. It uses
the base version.since that is what openssh2 uses. It's just that
pkg-config can't find openssl.pc since the base version does not create one
(or any .pc files).  there is never a run dependency on it:
# ldd /usr/local/bin/vlc
/usr/local/bin/vlc:
    libvlc.so.9 => /usr/local/lib/libvlc.so.9 (0x2c41c000)
    libvlccore.so.7 => /usr/local/lib/libvlccore.so.7 (0x2c634000)
    libidn.so.17 => /usr/local/lib/libidn.so.17 (0x2c8f8000)
    libiconv.so.3 => /usr/local/lib/libiconv.so.3 (0x2cb2a000)
    libdbus-1.so.3 => /usr/local/lib/libdbus-1.so.3 (0x2ce26000)
    libm.so.5 => /lib/libm.so.5 (0x2d078000)
    libthr.so.3 => /lib/libthr.so.3 (0x2d299000)
    libc.so.7 => /lib/libc.so.7 (0x2d4bc000)

In fact, I can just delete the openssl port as soon as I install vlc as the
port has no dependency on it at all. It has just become a "pseudo-build"
dependency.

I really hate using the ports version of openssl. It eventually will lead
to conflicts as ports linked to ports using the base openssl will also link
to different ports linked to the ports version and then those ports will
not start when the rtld checks for version mis-matches. I suggest that
configure should be patched to not check for openssl with pkg-config (or
check of it at all) sicne it's in FreeBSD out of the box.



As a side note, I get the "disturbing" warning:
configure: WARNING: unrecognized options: --disable-dv, --disable-loader,
--enable-qt4, --enable-real, --disable-smb, --disable-sqlite,
--disable-xosd, --with-qt-includes, --with-qt-libraries, --with-extra-libs,
--with-extra-includes
 which makes me suspect the port options are out of date, but this does not
break the build, it just means that some options are not honored.
-- 
R. Kevin Oberman, Network Engineer
E-mail: rkoberman at gmail.com


> On Mon, Oct 28, 2013 at 2:52 PM, Kevin Oberman <rkoberman at gmail.com>
> wrote:
> > Since the vlc port was updated last week I have been unable to update. I
> > have selected libssh2 in the configuration, but when configure is run, it
> > ways libssh2 is not found.
> > checking for SFTP... no
> > configure: error: Library libssh2 needed for sftp was not found
> > ===>  Script "configure" failed unexpectedly.
> > Please report the problem to multimedia at FreeBSD.org [maintainer] and
> attach
> > the "/usr/ports/multimedia/vlc/work/vlc-2.1.0/config.log" including the
> > output
> > of the failure of your make command. Also, it might be a good idea to
> > provide
> > an overview of all packages installed on your system (e.g. a
> > /usr/sbin/pkg_info
> > -Ea).
> > *** [do-configure] Error code 1
> >
> > Looking into the log I find:
> > configure:31648: checking for SFTP
> > configure:31655: $PKG_CONFIG --exists --print-errors "libssh2"
> > configure:31658: $? = 0
> > configure:31672: $PKG_CONFIG --exists --print-errors "libssh2"
> > configure:31675: $? = 0
> > configure:31689: result: no
> > Package libssl was not found in the pkg-config search path.
> > Perhaps you should add the directory containing `libssl.pc'
> > to the PKG_CONFIG_PATH environment variable
> > Package 'libssl', required by 'libssh2', not found
> > Package 'libcrypto', required by 'libssh2', not found
> >
> > But pkg-config has no problem with libssh2:
> > # pkg-config --exists --print-errors libssh2
> > # echo $?
> > 0
> > #
> >
> > configure for this sftp is a bit convoluted for my poor sh skills, but I
> > can't figure out why it's failing. It makes it through the tests at
> 31675,
> > but then files the library test. But I manually execute that test and it
> > passes.
> > # pkg-config --libs "libssh2"
> > -L/usr/local/lib -lssh2  -Wl,-rpath=/usr/lib:/usr/local/lib
> > # echo $?
> > 0
> > #
> >
> > Anyone with good sh ability want to look into this? In the interim, I
> have
> > re-installed vlc without support for sftp.
> >
> > If I don't se anything on this in te next day, I'll open a PR, but I'm
> > hoping that this is a trivial tweak that can be quickly be fixed by
> someone.
>
> --
> William Grzybowski
> ------------------------------------------
> Curitiba/PR - Brasil
>