[SoX-devel] Bug in sox-14.3.2/src/oss.c

Eric Wong normalperson at yhbt.net
Wed Oct 31 09:11:24 UTC 2012


Hans Petter Selasky <hselasky at c2i.net> wrote:
> Hi,
> 
> Line buffering should be off, but this statement leads to SOX reading 1 and 
> one byte from the recording DSP device under FreeBSD:
> 
>     /* Change to non-buffered I/O */
>     setvbuf(ft->fp, NULL, _IONBF, sizeof(char) * file->size);
>     return(SOX_SUCCESS);
> 
> I think this flag should be used instead:
> 
>            _IOFBF  fully buffered
> 
> I've tested this change and it works like expected.
> 
> Any comments?

The code you're changing in src/oss.c no long applies to SoX 14.4.0,
how does 14.4.0 work out-of-the-box for you?


More information about the freebsd-multimedia mailing list