Fwd: Trivial sound fix that should be in 9.

Hans Petter Selasky hselasky at c2i.net
Sat Sep 10 10:24:44 UTC 2011

On Saturday 10 September 2011 11:17:54 Andriy Gapon wrote:
> Can anyone on this list please review the following PR and patch?
> It seems sufficiently trivial, so if nobody reviews or objects to it, I
> will try to ask for RE approval of this patch in a couple of days.
> -------- Original Message --------
> A while back a colleague sent this fix in for OSS4 it's extremely trivial
> and should really make it into 9 as more software is being affected.
>   http://www.freebsd.org/cgi/query-pr.cgi?pr=156433
> Since ariff has been idle for a while it was suggested I send an email to
> the last person to touch the file.


Except for the style, the patch looks good. IOCTL arguments are however not 
bigger than 32-bit, even though unsigned long is used. I think the problem 
here is sign-extension from int to unsigned long. If the xcmd was unsigned 
int, that would solve the problem aswell.


More information about the freebsd-multimedia mailing list