dsp mmap change

Kostik Belousov kostikbel at gmail.com
Fri May 6 13:52:46 UTC 2011

On Fri, May 06, 2011 at 11:55:00AM +0300, Andriy Gapon wrote:
> I would like to ask for a review and/or testing of the following patch:
> http://people.freebsd.org/~avg/dev_dsp_mmap.diff
> It's supposed to fix an issue described here:
> http://lists.freebsd.org/pipermail/freebsd-multimedia/2011-February/011691.html
> In short, the following pseudo-code should do the right thing:
> fd = open(/dev/dsp, O_RDWR);
> mmap(PROT_READ, fd);
> mmap(PROT_WRITE, fd);
> Thank you!

I think that you have to call PCM_GIANT_LEAVE() when returning
EINVAL on the vm_pager_alloc() failure.

Your patch hardcodes an assumption that sndbufs are always
contiguous. I was unable to convince myself that this is true.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-multimedia/attachments/20110506/9af0432f/attachment.pgp

More information about the freebsd-multimedia mailing list