multimedia/pvr250 port doesn't compile on FreeBSD 8

[Torfinn Ingolfsen]

On Fri, 21 May 2010 09:35:16 +0200
Stefan Ehmann <shoesoft at gmx.net> wrote:

> On Thursday 20 May 2010 21:52:35 Torfinn Ingolfsen wrote:
> > 
> > Hmm, cxm_i2c.c already contains that line.
> > root at kg-fil# grep DRIVER ./work/dev/cxm/cxm_i2c.c
> > DRIVER_MODULE(cxm_iic, cxm, cxm_iic_driver, cxm_iic_devclass, 0, 0);
> > root at kg-fil# uname -a
> > FreeBSD kg-fil.kg4.no 8.0-STABLE FreeBSD 8.0-STABLE #3: Thu Dec 31 00:34:23
> > CET 2009     root at kg-fil.kg4.no:/usr/obj/usr/src/sys/GENERIC  amd64
> > 
> > Do I also need to "hack" minor?
> 
> These lines are not the same. You need them both:
> 
> --- pvrxxx.orig/dev/cxm/cxm_i2c.c       2009-12-05 13:31:54.000000000 +0100
> +++ pvrxxx/work/dev/cxm/cxm_i2c.c       2009-12-01 08:52:29.000000000 +0100
> @@ -131,6 +131,7 @@
>  #endif
>  MODULE_VERSION(cxm_iic, 1);
>  DRIVER_MODULE(cxm_iic, cxm, cxm_iic_driver, cxm_iic_devclass, 0, 0);
> +DRIVER_MODULE(iicbb, cxm_iic, iicbb_driver, iicbb_devclass, 0, 0);

Doh! That's what I get for trying to work with this so late. Sorry about that.
Anyway, now I have fixed it:
root at kg-fil# grep DRIVER work/dev/cxm/cxm_i2c.c
DRIVER_MODULE(cxm_iic, cxm, cxm_iic_driver, cxm_iic_devclass, 0, 0);
DRIVER_MODULE(iicbb, cxm_iic, iicbb_driver, iicbb_devclass, 0, 0);

But still it fails:
root at kg-fil# make
===>  Configuring for pvrxxx-09042008
cd /usr/ports/multimedia/pvrxxx/work/modules/cxm;  cd cxm_cx25840fw; tar xzf /usr/ports/distfiles//firmware.tar.gz v4l-cx25840.fw;  cd ../cxm_decfw; tar xzf /usr/ports/distfiles//firmware.tar.gz v4l-cx2341x-dec.fw;  cd ../cxm_encfw; tar xzf /usr/ports/distfiles//firmware.tar.gz v4l-cx2341x-enc.fw
===>  Building for pvrxxx-09042008
cd /usr/ports/multimedia/pvrxxx/work/modules/cxm; make
===> cxm (all)
Warning: Object directory not changed from original /usr/ports/multimedia/pvrxxx/work/modules/cxm/cxm
@ -> /usr/src/sys
machine -> /usr/src/sys/amd64/include
:> opt_cxm.h
awk -f @/tools/makeobjops.awk @/kern/bus_if.m -h
awk -f @/tools/makeobjops.awk @/kern/device_if.m -h
awk -f @/tools/makeobjops.awk @/dev/iicbus/iicbb_if.m -h
awk -f @/tools/makeobjops.awk @/dev/pci/pci_if.m -h
awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -p
awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -q
awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -h
cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc  -I../../.. -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow  -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -c /usr/ports/multimedia/pvrxxx/work/modules/cxm/cxm/../../../dev/cxm/cxm.c
/usr/ports/multimedia/pvrxxx/work/modules/cxm/cxm/../../../dev/cxm/cxm.c: In function 'cxm_open':
/usr/ports/multimedia/pvrxxx/work/modules/cxm/cxm/../../../dev/cxm/cxm.c:2484: error: invalid operands to binary &
/usr/ports/multimedia/pvrxxx/work/modules/cxm/cxm/../../../dev/cxm/cxm.c: In function 'cxm_close':
/usr/ports/multimedia/pvrxxx/work/modules/cxm/cxm/../../../dev/cxm/cxm.c:2517: error: invalid operands to binary &
/usr/ports/multimedia/pvrxxx/work/modules/cxm/cxm/../../../dev/cxm/cxm.c: In function 'cxm_read':
/usr/ports/multimedia/pvrxxx/work/modules/cxm/cxm/../../../dev/cxm/cxm.c:2565: error: invalid operands to binary &
/usr/ports/multimedia/pvrxxx/work/modules/cxm/cxm/../../../dev/cxm/cxm.c: In function 'cxm_ioctl':
/usr/ports/multimedia/pvrxxx/work/modules/cxm/cxm/../../../dev/cxm/cxm.c:2679: error: invalid operands to binary &
/usr/ports/multimedia/pvrxxx/work/modules/cxm/cxm/../../../dev/cxm/cxm.c: In function 'cxm_poll':
/usr/ports/multimedia/pvrxxx/work/modules/cxm/cxm/../../../dev/cxm/cxm.c:3266: error: invalid operands to binary &
*** Error code 1

Stop in /usr/ports/multimedia/pvrxxx/work/modules/cxm/cxm.
*** Error code 1

Stop in /usr/ports/multimedia/pvrxxx/work/modules/cxm.
*** Error code 1

Stop in /usr/ports/multimedia/pvrxxx.

Any hints?
-- 
Torfinn