Fwd: cx88 driver for FreeBSD

[Jason Harmening]

I'm forwarding this to the list as a heads-up...cx88 build is broken
on 8-STABLE as of a few days ago (and is already marked broken on
9-CURRENT for the same reason).  The fix is included below.  Hopefully
the newbus locking changes will come back shortly, at which point I'll
do a new release w/ a fix.  Sorry for the inconvenience.


---------- Forwarded message ----------
From: Jason Harmening <jason.harmening at gmail.com>
Date: Thu, Jan 14, 2010 at 10:59 AM
Subject: Re: cx88 driver for FreeBSD
To: R J Thompson <rjt2200 at googlemail.com>


On Thu, Jan 14, 2010 at 10:14 AM, R J Thompson <rjt2200 at googlemail.com> wrote:
> Hi Jason
>
> First of all, thankyou for taking the time to write this driver, I am
> looking to use it on a FreeBSD MythTV backend server with a Hauppauge Nova-T
> PCI card.  The system is running 8-STABLE (built from the source tree as of
> today), however when I compile cx88 from the ports I have an error as
> follows:
>
> cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc
>  -I../common -I../iicdev -I. -I@ -I@/contrib/altq -finline-limit=8000
> --param inline-unit-growth=100 --param large-function-growth=1000
> -fno-common  -mno-align-long-strings -mpreferred-stack-boundary=2  -mno-mmx
> -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -fstack-protector
> -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls -Wnested-externs
> -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline
> -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -c cx88_i2c.c
> cc1: warnings being treated as errors
> cx88_i2c.c: In function 'cx88_i2c_lock_devtree':
> cx88_i2c.c:194: warning: implicit declaration of function 'newbus_xlock'
> cx88_i2c.c:194: warning: nested extern declaration of 'newbus_xlock'
> cx88_i2c.c: In function 'cx88_i2c_unlock_devtree':
> cx88_i2c.c:203: warning: implicit declaration of function 'newbus_xunlock'
> cx88_i2c.c:203: warning: nested extern declaration of 'newbus_xunlock'
> *** Error code 1
>
> Stop in /usr/ports/multimedia/cx88/work/cx88-1.2.1/i2c.
> *** Error code 1
>
> Stop in /usr/ports/multimedia/cx88/work/cx88-1.2.1.
> *** Error code 1
>
> Stop in /usr/ports/multimedia/cx88.
>
> Not sure what this means?  Any information or advice welcome.
>
> Cheers
>
> Richard
>
>

Back in August, newbus_x[un]lock() was added briefly to 8-CURRENT, and
so I added a __FreeBSD_version check to determine whether to use the
new functions or do locking the old way w/ Giant.  Then they decided
to remove the new functions for 8.0-RELEASE, but supposedly they'll be
coming back shortly.  I'm waiting for that to happen before I release
a new version w/ the correct __FreeBSD_version check.  In the
meantime, you can edit cx88_i2c.c and remove the check so that it just
uses Giant.

Sorry for the inconvenience,
Jason