[PATCH] multimedia/x264: update to 0.0.20091124

[Wes Morgan]

On Thu, 26 Nov 2009, Gea-Suan Lin wrote:

>
>> Submitter-Id:	current-users
>> Originator:	Gea-Suan Lin
>> Organization:
>> Confidential:	no
>> Synopsis:	[PATCH] multimedia/x264: update to 0.0.20091124
>> Severity:	non-critical
>> Priority:	low
>> Category:	ports
>> Class:		update
>> Release:	FreeBSD 7.2-RELEASE-p3 i386
>> Environment:
> System: FreeBSD colo-p.gslin.org 7.2-RELEASE-p3 FreeBSD 7.2-RELEASE-p3 #0: Sat Aug 22 10:48:39 CST 2009
>> Description:
> - Update to 0.0.20091124
>
> Port maintainer (multimedia at FreeBSD.org) is cc'd.
>
> Generated with FreeBSD Port Tools 0.99
>> How-To-Repeat:
>> Fix:
>
> --- x264-0.0.20091124.patch begins here ---
> diff -ruN --exclude=CVS /usr/ports/multimedia/x264/Makefile /home/staff/gslin/work/ports/x264/Makefile
> --- /usr/ports/multimedia/x264/Makefile	2009-11-23 04:28:29.000000000 +0800
> +++ /home/staff/gslin/work/ports/x264/Makefile	2009-11-26 00:13:16.000000000 +0800
> @@ -6,7 +6,7 @@
> #      $Id: Makefile 30 2006-10-30 22:15:26Z buhnux $
>
> PORTNAME=	x264
> -PORTVERSION=	0.0.20081218
> +PORTVERSION=	0.0.20091124
> CATEGORIES=	multimedia
> MASTER_SITES=	http://downloads.videolan.org/pub/videolan/x264/snapshots/ \
> 		http://samples.mplayerhq.hu/yuv4mpeg2/:pgo
> @@ -16,7 +16,7 @@
> EXTRACT_ONLY=	${PORTNAME}-snapshot-${PORTVERSION:S/0.0.//}-2245${EXTRACT_SUFX}
>
> MAINTAINER=	multimedia at FreeBSD.org
> -COMMENT?=	Multimedia library and tool for encoding H.264/AVC video streams
> +COMMENT=	Multimedia library and tool for encoding H.264/AVC video streams
>
> BUILD_DEPENDS=	yasm>=0.6.0:${PORTSDIR}/devel/yasm
>
> @@ -36,7 +36,7 @@
>
> CONFIGURE_ARGS+=	--extra-cflags="${CPPFLAGS} ${CFLAGS} -fPIC -I${LOCALBASE}/include -I${LOCALBASE}/include" \
> 			--extra-ldflags="${LDFLAGS} -L${LOCALBASE}/lib -L${LOCALBASE}/lib" \
> -			--enable-shared
> +			--enable-shared --disable-asm

I'm pretty certain that this will not work on amd64. The gcc internal 
"log2f" function won't be picked up. See this email for a fix:

http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-March/009819.html

Would it also be possible to add knobs for enabling the internal assembler 
and adding dependencies on both binutils and gcc 4.4 from ports? I've been 
using a snapshot built this way for about 2 weeks now doing some pretty 
heavy encoding and have no problems other than the log2f patch.