snd_envy24ht regression in 8.0 (patch included)

[Stefan Ehmann]

On Saturday 05 December 2009 01:00:54 Carl Johan Gustavsson wrote:
> Yamagi Burmeister wrote:
> > Hello,
> > I've got a Audiotrak Prodigy HD2 soundcard, based upon the VIA
> > Envy24HT-s chipset. Dmesg output is:
...
> >
> > In FreeBSD 7.2 it worked just like a charm but after upgrading to 8.0
> > the left stereo channel is only half as loud as the right one. It can be
> > reproduced with either speakers and headphones. I tracked it down to a
> > change in revision 188480 of spicds.c, the change "fix: stupid bug with
> > volume control for AK4396" breaks volume control for me. The attached
> > patch fixes the problem by reverting the specific change but I guess
> > it'll break some other cards again.
> >
> > An other possible work around is to double the volume of the left
> > channel via the mixer.
> Hi,
> 
> That patch was partly correct but it did only fix the problem on the right
> channel, the left one exhibits a similar error. Logical operators in case
> labels does not work well in C, or at least not as the original writer
> expected :)
> 
> Please revert your changes and try the attached patch.

The patch fixes the balance problems on my envy24 card that had similar 
problems.

-- 
Stefan