speex upgrade to 1.1.12 ?

[Luigi Rizzo]

On Thu, Feb 22, 2007 at 11:44:27AM -0600, Jeremy Messenger wrote:
...
> > http://info.iet.unipi.it/~luigi/FreeBSD/speex-devel-20070221.tgz
> 
> Why remove two patches? They are not need anymore? I can build with two  

apparently yes they are not needed anymore.

> patches w/out any of problem. As for the Makefile, I have done a bit tweak  
>  from your changes. Example:
> -PORTVERSION -> DISTVERSION.
> -CONFLICTS=speex-*, this is incorrect and is too general. It should be  
> speex-[0-9]*.
> -Remove 'devel version' and peroid. An end of peroid in the sentence is  
> illegal in COMMENT.
> -INSTALLS_SHLIB -> USE_LDCONFIG.
> -CONFIGURE_TARGET -> USE_GNOME=gnometarget
> -Add USE_GNOME=ltverhack to avoid shared library version bump to often by  
> fix libtool bug.
> -Add CONFIGURE_ENV by add -I/-L${LOCALBASE}/[...] to make it works when  
> install speex in the different prefix.

fine, most of the things you note below were just inherited from
the previous one (PORTVERSION, CONFIGURE_TARGET, INSTALL_SHLIBS).

> -Remove MAKE_ENV, I don't think it is need.

LDFLAGS was added because some of the code uses the math library and
	-lm is not included by default on my box at least (RELENG_6).
	Maybe some of the other changes you made also imply -lm ?

CFLAGS were just added to build with stricter compiler flags,
	so it is not strictly necessary;

> 
> I am not done (have to go back to class soon) with it yet, so if you have  
> any of question then let me know.

nothing else.

cheers
luigi