spigen problem

[Adrian Chadd]

hi!

this looks ok to me. I'll go commit this tonight.


-a

On Mon, 29 Apr 2019 at 19:03, Mori Hiroki <yamori813 at yahoo.co.jp> wrote:
>
> Hi.
>
> I'm sorry. This is mtk_spi_v1.c issue. Current code hard depend
> flash access.
>
> I add workadound for this code and put review.
>
> https://reviews.freebsd.org/D20101
>
> Thanks
>
> Hiroki Mori
>
> ----- Original Message -----
> > From: Emmanuel Vadot <manu at bidouilliste.com>
> > To: Ian Lepore <ian at freebsd.org>
> > Cc: "freebsd-mips at freebsd.org" <freebsd-mips at freebsd.org>
> > Date: 2019/4/30, Tue 03:23
> > Subject: Re: spigen problem
> >
> > On Mon, 29 Apr 2019 12:13:41 -0600
> > Ian Lepore <ian at freebsd.org> wrote:
> >
> >>  On Mon, 2019-04-29 at 19:57 +0200, Emmanuel Vadot wrote:
> >>  > On Mon, 29 Apr 2019 11:34:34 -0600
> >>  > Ian Lepore <ian at freebsd.org> wrote:
> >>  >
> >>  > > On Tue, 2019-04-30 at 02:18 +0900, Mori Hiroki wrote:
> >>  > > > Hi
> >>  > > >
> >>  > > > I add small spi lcd on RT3050. This lcd controller is
> > S6D0151.
> >>  > > >
> >>  > > > S6D0151 transfer is tree byte command then tree byte data.
> >>  > > >
> >>  > > > I use spigen mruby rapper. This rapper use
> > SPIGENIOC_TRANSFER.
> >>  > > >
> >>  > > > I try to send tree byte command. But spi transfer is six
> > byte.
> >>  > > >
> >>  > > > This is reason.
> >>  > > >
> >>  > > > sys/dev/spibus/spigen.c
> >>  > > >
> >>  > > >         error = copyin(st->st_command.iov_base,
> > transfer.tx_cmd,
> >>  > > >            transfer.tx_cmd_sz = transfer.rx_cmd_sz = st-
> >>  > > > > st_command.iov_len);
> >>  > > >
> >>  > > >
> >>  > > > This lcd not work six byte transfer.
> >>  > > >
> >>  > > > How do I fix this ?
> >>  > > >
> >>  > > > Regards
> >>  > > >
> >>  > > > Hiroki Mori
> >>  > > >
> >>  > >
> >>  > > I'm not sure what you mean by "This is the reason",
> > that code sets
> >>  > > up
> >>  > > the transfer for exactly as many bytes as you requested in
> >>  > > st_command.iov_len.  If you set that to three bytes, only three
> >>  > > bytes
> >>  > > will be transfered.
> >>  > >
> >>  > > -- Ian
> >>  >
> >>  >  I guess that Mori-San wants to transfer 3 bytes but receive 6, if
> >>  > it's
> >>  > that you need to set tx_cmd_sz with dummy bytes count too. The tx
> >>  > buffer will also need to contain the dummy bytes values.
> >>  >
> >>
> >>  If you mean send 3 command bytes and read back 3 response bytes, then
> >>  set st_command.iov_len to 3 and st_data.iov_len to 3.
> >>
> >>  -- Ian
> >
> > Ah right, forgot about command/data being splitted.
> >
> > --
> > Emmanuel Vadot <manu at bidouilliste.com> <manu at freebsd.org>
> > _______________________________________________
> > freebsd-mips at freebsd.org mailing list
> > https://lists.freebsd.org/mailman/listinfo/freebsd-mips
> > To unsubscribe, send any mail to
> > "freebsd-mips-unsubscribe at freebsd.org"
> >
>
> _______________________________________________
> freebsd-mips at freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-mips
> To unsubscribe, send any mail to "freebsd-mips-unsubscribe at freebsd.org"