[PATCH] MikroTik RB450G support

[Patrick Kelsey]

On Sat, Mar 10, 2012 at 10:44 PM, Adrian Chadd <adrian at freebsd.org> wrote:
> Thanks for this!

Thanks for taking a look!

> The arge patch for board info should be something chip specific,
> rather than always compiled in.
>
> The board model thing should be an environment variable, rather than
> hard-coded in the driver.  What's it needed for, anyway? Are the MAC
> addresses reversed?

On the RB450G, the typical config seems to be to have arge1 connected
to the lowest numbered front panel port, with the base MAC address
assigned.  In the updated patch (attached), I did away with the board
model logic and replaced it with a mac_offset hint, which is a generic
solution that is also more concise and flexible.

I also cleaned up the patch to ar71xx_machdep.c, which was needlessly
putting the board_model in a global when it was already available in
the environment via the existing HEAD code.  The only change remaining
then for the RB450 is to extract the mem size from argv.

> The MII speed thing is good, I've been wondering about adding more MII
> config stuff to the ar71xx code. But we'll have to ensure it's set
> correctly for the AR91xx and AR724x code.

I currently have no knowledge of the AR91xx and AR724x requirements.
As far as I can tell, and I'm not authoritative on this by any means,
setting the MII speed on AR71xx  is only relevant when operating in
MII/RMII mode.  The RB450G runs in RGMII mode, and empirically doesn't
seem to be affected by setting the MII speed to any value, so I'd have
no objection if this part of the patch is put off until questions can
be resolved.  Perhaps this should be broken out into a separate patch.

-Patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rb450_support_pass2.diff
Type: application/octet-stream
Size: 8837 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-mips/attachments/20120311/946b4921/rb450_support_pass2.obj