Minor fixup for the MIPS SMP platform code.

Andrew Duane aduane at juniper.net
Mon May 17 14:44:19 UTC 2010


A really minor nit: in sys/mips/rmi/xlr_machdep.c, you might as well put the assert for "Interrupts enabled" before setting the COP_2 and COP_0 bits in the stat register. There's no real difference of effect, the code just feels a bit cleaner to check for validity before setting anything else.

/Andrew
 
 

> -----Original Message-----
> From: owner-freebsd-mips at freebsd.org 
> [mailto:owner-freebsd-mips at freebsd.org] On Behalf Of C. Jayachandran
> Sent: Monday, May 17, 2010 10:33 AM
> To: Neel Natu
> Cc: freebsd-mips at freebsd.org
> Subject: Minor fixup for the MIPS SMP platform code.
> 
> The attached patch (also at 
> http://sites.google.com/site/cjayachandran/files)
> has two changes:
> - moves the intr masking code to platform_init_ap, so that we 
> can avoid the
> #ifdef for XLR
> - adds a platform_smp_topo() function so that platforms can 
> define their
> topology
> 
> I've also attempted to fixup sys/mips/sibyte to reflect these 
> changes, but
> it might need further work.
> sys/mips/cavium also might need similar changes for SMP.
> 
> Please review and apply if the changes are okay.
> 
> Thanks,
> JC.
> 


More information about the freebsd-mips mailing list