Merging 64 bit changes to -HEAD - part 4

Juli Mallett jmallett at FreeBSD.org
Fri Jul 9 21:08:04 UTC 2010


On Fri, Jul 9, 2010 at 13:46, M. Warner Losh <imp at bsdimp.com> wrote:
> pmap_map should likely have a comment to the effect:
>  * For memory that's directly mappable, we return the direct map
>  * address.  For other addresses, we create a map.

Doesn't it already?

 *	The value passed in '*virt' is a suggested virtual address for
 *	the mapping. Architectures which can support a direct-mapped
 *	physical to virtual region can return the appropriate address
 *	within that region, leaving '*virt' unchanged. Other
 *	architectures should map the pages starting at '*virt' and
 *	update '*virt' with the first usable address after the mapped
 *	region.

> : mips-ddb-64.patch (from Juli's branch)
> : Minor fixups for ddb support.
>
> Can you explain the casting for all the calls to kbdpeek*?

Yes.  sp is (or should be) a register_t.  You can't go from a
register_t to a pointer on n32.  Even if we don't intend to support
n32 kernels from head, we shouldn't make n32 harder by using the wrong
types without casts :)

Juli.


More information about the freebsd-mips mailing list