Patch: SMP support for MIPS

M. Warner Losh imp at bsdimp.com
Sat Feb 6 03:05:17 UTC 2010


In message: <dffe84831002051827r430c7fb6le3c3506bd6d38a03 at mail.gmail.com>
            Neel Natu <neelnatu at gmail.com> writes:
: I have put the diff here for review:
: http://people.freebsd.org/~neel/mips_smp_patch/diff.txt

+ /*
+  * XXX
+   * SMP kernels must delay pcpu initialization until after
+    * TLB has been flushed and initialized (see mips_cpu_init())
+     */
+     if (pcpu_find(0) == NULL)
+     	 mips_pcpu0_init();
+

The practical upshot of this change is that panic() prior to this
point will fault.  Is there some way to avoid this?

The rest of these changes look fairly good.  I'll likely comment on a
few nits later that I saw once I have the time to devote to it.

Warner


More information about the freebsd-mips mailing list