[Bug 237054] java/openjdk11: Needs to be integrated into bsd.java.mk

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237054

--- Comment #6 from Tommy P <tommyhp2 at gmail.com> ---
(In reply to Greg Lewis from comment #5)
Hi Greg,

Without the patch, specifying any of the below would cause errors during
building of various ports using Java:

JAVA_VERSION=12
JAVA_VERSION=12.0

The patch conforms to previous JAVA_VERSION usage:

1.6
1.7
1.8
11.0
12.0

Using JAVA_VERSION=12.0 and JAVA_VENDOR=openjdk allow my systems to have only 1
JDK.  I haven't tried using only 12.0+ yet but the regex pattern should match
and also allow future versions 11.1 or 12.1 with minor changes.  Any existing
ports specifying JAVA_VERSION=1.8+ would build such as sysutils/facter (for
sysutils/puppet6) with additional patches:

*) BR 237991 - java/openjdk12 is missing java wrapper for RUN_DEPENDS in
Makefile which provides various java commands in /usr/local/bin. 
java/openjdk11 is also missing the wrapper.  If JDK12 is the only java tool
available, any app searching for java commands in the path would fail to
execute and ports would also failed to build.  Of the 3 OpenJDKs 8, 11, 12,
only 8 provides the wrapper.
*) BR 237990 - sysutils/facter specifies '-soucre 1.6' but JDK12 requires
'-source 7'

I've done some spot tests with Tomcat 9.0.20 various (Servlet, JSP, and
WebSocket) examples without any issue.  This is the server information reported
by Tomcat's manager:

Tomcat Version  JVM Version     JVM Vendor      OS Name OS Version      OS
Architecture Hostname        IP Address
Apache Tomcat/9.0.20    12+12-2 Oracle Corporation      FreeBSD
11.2-RELEASE-p10        amd64   freebsd.test.domain     10.x.x.x

Snippets from /usr/local/etc/rc.d/puppet*

: ${puppetdb_java_home="/usr/local/openjdk12"}
: ${puppetserver_java_home="/usr/local/openjdk12"}

And puppetserver does run with default config as seen from log:

2019-05-21T13:58:53.400-07:00 INFO  [async-dispatch-2]
[o.e.j.s.AbstractConnector] Started ServerConnector at e3c57e4{SSL,[ssl,
http/1.1]}{0.0.0.0:8140}
2019-05-21T13:58:53.401-07:00 INFO  [async-dispatch-2] [o.e.j.s.Server] Started
@56880ms
2019-05-21T13:58:53.415-07:00 INFO  [async-dispatch-2] [p.t.s.s.status-core]
Starting background monitoring of cpu usage metrics
2019-05-21T13:58:53.440-07:00 INFO  [async-dispatch-2] [p.t.s.s.status-service]
Registering status callback function for service 'status-service', version
1.1.0
2019-05-21T13:58:53.445-07:00 INFO  [async-dispatch-2] [p.t.s.s.status-service]
Registering status service HTTP API at /status
2019-05-21T13:58:53.478-07:00 INFO  [async-dispatch-2]
[o.e.j.s.h.ContextHandler] Started
o.e.j.s.h.ContextHandler at 1e55980e{/status,null,AVAILABLE}
2019-05-21T13:58:53.546-07:00 INFO  [async-dispatch-2] [p.s.m.master-service]
Puppet Server has successfully started and is now ready to handle requests
2019-05-21T13:58:53.549-07:00 INFO  [async-dispatch-2]
[p.s.l.legacy-routes-service] The legacy routing service has successfully
started and is now ready to handle requests
2019-05-21T13:58:53.556-07:00 INFO  [async-dispatch-2]
[p.s.a.analytics-service] Puppet Server Update Service has successfully started
and will run in the background

I'm aware of only one major issue with puppet is that I think the major changes
FreeBSD 12 in how the OS handles filesystem hooks breaking jruby.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233766

Because of that, I'm holding back on upgrade to 12.0 :(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.