Fwd: Request for Approval: Backport of JDK-8205965: SIGSEGV on write to NativeCallStack::EMPTY_STACK

[Dimitry Andric]

FYI. I'm testing this patch (at http://cr.openjdk.java.net/~zgu/8205965_8u/webrev.00/ ) locally, which reverts the fix we committed for https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225054 in https://svnweb.freebsd.org/ports?view=revision&revision=459368, and solves the issue in another way.

-Dimitry

> Begin forwarded message:
> 
> From: Leslie Zhai <zhaixiang at loongson.cn>
> Subject: Re: Request for Approval: Backport of JDK-8205965: SIGSEGV on write to NativeCallStack::EMPTY_STACK
> Date: 19 September 2018 at 03:22:48 CEST
> To: Zhengyu Gu <zgu at redhat.com>, Seán Coffey <sean.coffey at oracle.com>
> Cc: jdk8u-dev <jdk8u-dev at openjdk.java.net>, Dimitry Andric <dimitry at andric.com>
> 
> Hi Zhengyu,
> 
> Thanks for your sponsor!
> 
> I will run jtreg towards:
> 
> * jdk8u-dev, base on 8722:16b9bbfaa450, applied with the patch, compiled with clang-6 and clang-8-dev
> 
> * jdk8u-dev, base on 8722:16b9bbfaa450, compiled with gcc-6.4.3 and gcc-9-dev
> 
> Then run jtdiff on Linux X86.
> 
> Hi Dimitry,
> 
> Please verify the patch on FreeBSD compiled with clang-6, thanks a lot!
> 
> Thanks,
> 
> Leslie Zhai
> 
> 
> 在 2018年09月19日 07:06, Zhengyu Gu 写道:
>> Hi Leslie,
>> 
>> The backport is approved.
>> 
>> Please send me *committed* patch [1] after proper tests, I will sponsor it for you.
>> 
>> Thanks,
>> 
>> -Zhengyu
>> 
>> [1] http://openjdk.java.net/sponsor/ Section 3
>> 
>> You should use commit message from original patch and add yourself as contributor, ex.
>> 
>> 8205965: SIGSEGV on write to NativeCallStack::EMPTY_STACK
>> Summary: Made EMPTY_STACK non-const, so it will not be placed in read-only BSS section.
>> Reviewed-by: stuefe, martin
>> Contributed-by: zhaixiang at loongson.cn
>> 
>> 
>> 
>> On 09/18/2018 06:28 PM, Seán Coffey wrote:
>>> Approved for jdk8u-dev.
>>> 
>>> regards,
>>> Sean.
>>> 
>>> 
>>> On 18/09/2018 07:48, Leslie Zhai wrote:
>>>> Hi Zhengyu,
>>>> 
>>>> I would like to backport the fix for:
>>>> 
>>>> https://bugs.openjdk.java.net/browse/JDK-8205965
>>>> 
>>>> To OpenJDK 8 updates dev:
>>>> 
>>>> http://hg.openjdk.java.net/jdk8u/jdk8u-dev
>>>> 
>>>> The fix is mostly the same as the version that was committed in 12, here is the patch:
>>>> 
>>>> http://cr.openjdk.java.net/~zgu/8205965_8u/webrev.00/
>>>> 
>>>> The patch was reviewed, thanks for your review!  Here is the relevant thread:
>>>> 
>>>> http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-September/007860.html
>>>> 
>>>> A patch by Loongson!  Please sponsor it, thanks a lot!
>>>> 
>>> 
> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 223 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.freebsd.org/pipermail/freebsd-java/attachments/20180919/6f150872/attachment.sig>