[Bug 225054] java/openjdk* : fails to build with clang 6.0 (blocks 571 ports)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225054

Jung-uk Kim <jkim at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jkim at FreeBSD.org
             Status|New                         |Open

--- Comment #2 from Jung-uk Kim <jkim at FreeBSD.org> ---
This patch does not look good.  The previous inline assembly should generate
something like this:

        je      .Ltmp0
        lock
.Ltmp0:
        cmpxchgl        %ecx, (%edi)

Assembled:

   4:   0f 84 01 00 00 00       je     b <test+0xb>
   a:   f0 67 0f b1 0f          lock addr32 cmpxchg %ecx,(%edi)

Your patch will generate something like this:

        je      .Ltmp0
.Ltmp0:
        lock
        cmpxchgl        %ecx, (%edi)

Assembled:

   4:   0f 84 00 00 00 00       je     a <test+0xa>
   a:   f0 67 0f b1 0f          lock addr32 cmpxchg %ecx,(%edi)

As you can see, this patch *always* adds the prefix for cmpxchg.

-- 
You are receiving this mail because:
You are the assignee for the bug.