Remove dead code from java/cacao/Makefile

[René Ladan]

On 03-12-2017 18:04, Gerald Pfeifer wrote:
> On Sun, 28 May 2017, Gerald Pfeifer wrote:
>> I did not propose to remove that option, I merely wanted to relay
>> that (a) currently this alternative codepath is simply broken and
>> (b) remove three lines of dead code at least.
> Let me follow-up on this again.
>
> Rene, I saw that you recently updated java/cacao.  Can you approve?
You would have to ask java@, I just updated the port to use a supported
version of bootstrap-openjdk and then fixed my previous commit.
> I verified that WITH_GCC has exactly two occurrences in the _entire_
> Ports tree, and that is this dead code in java/cacao/Makefile.
>
> Any real objections towards removing this _dead_ code?
So WITH_GCC is not defined anywhere in usr/ports/Mk/ nor in lang/gcc*,
which would indeed render the if statement useless. So yes, the change
should be fine. You could also remove the GCC_SUFX?=46 line?
> Gerald
>
> PS: There is more, but let's focus on this most straightforward one
> for now where I'm surprised (a) nobody else cared and (b) even this 
> was hard to get in.
>
> Index: java/cacao/Makefile
> ===================================================================
> --- java/cacao/Makefile	(revision 455410)
> +++ java/cacao/Makefile	(working copy)
> @@ -37,9 +37,6 @@
>  JAR=		${LOCALBASE}/bootstrap-openjdk6/bin/jar
>  JAVAC=		${LOCALBASE}/bootstrap-openjdk6/bin/javac
>  .else
> -.if defined(WITH_GCC)
> -GCC_SUFX=	${WITH_GCC:S/.//}
> -.endif
>  GCC_SUFX?=	46
>  BUILD_DEPENDS+=	gcj${GCC_SUFX}:lang/gcc${GCC_SUFX}
>  EXTRA_PATCHES=	${FILESDIR}/gcj.patch
>
René