java/icedtea-web and libxul

[Jung-uk Kim]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2012-11-09 15:14:12 -0500, Lena wrote:
> The last java/icedtea-web/Makefile update 
> http://www.freebsd.org/cgi/cvsweb.cgi/ports/java/icedtea-web/Makefile.diff?r1=1.24;r2=1.25;f=h
>
> 
adds:
> 
> USE_GECKO=      libxul
> 
> What for? I have www/firefox installed including
> /usr/local/lib/firefox/libxul.so . Why do I need now to build and
> install also www/libxul port?

You are not asking me to add firefox as a run-time dependency, are
you? :-P

Seriously, we only had it for a build dependency before this commit:

BUILD_DEPENDS+=
${LOCALBASE}/libdata/pkgconfig/mozilla-plugin.pc:${PORTSDIR}/www/libxul19

However, I decided to do the right thing because I didn't want to keep
chasing Gecko infrastructure changes.  Unfortunately, bsd.gecko.mk
does not have any way to separate build dependency and run-time
dependency:

...
_GECKO_ALL=     libxul libxul19

libxul_PLIST=           libxul>=10
libxul19_PLIST=         libxul<2

.for gecko in ${_GECKO_ALL}
${gecko}_PORTSDIR?=     www
${gecko}_DEPENDS?=      ${PORTSDIR}/${${gecko}_PORTSDIR}/${gecko}
${gecko}_PLIST?=        ${LOCALBASE}/lib/${gecko}/libgtkembedmoz.so
.endfor
...
.if defined(GECKO) && ${_GECKO_ALL:M${GECKO}}!=""
BUILD_DEPENDS+= ${${GECKO}_PLIST}:${${GECKO}_DEPENDS}
RUN_DEPENDS+=   ${${GECKO}_PLIST}:${${GECKO}_DEPENDS}
.else
IGNORE= Unable to find a supported gecko, please check USE_GECKO
.endif
...

If you still think it is not acceptable, please ask gecko@ for
improvement in this area.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iEYEARECAAYFAlCdhOwACgkQmlay1b9qnVMGUQCeLFd131ttnBg6KTWte/H9jWgA
OS4AoMOm5eoAYX9uqjymuGDBAPap3qkX
=yVPM
-----END PGP SIGNATURE-----