[RFC] New Port: Eclipse Java Compiler, java/eclipse-ecj

[Jason Helfman]

On Tue, Mar 20, 2012 at 12:41:02PM -0400, Jung-uk Kim thus spake:
>On Monday 19 March 2012 09:58 pm, Greg Lewis wrote:
>> On Mon, Mar 19, 2012 at 04:08:18PM -0700, Jason Helfman wrote:
>> > On Mon, Mar 19, 2012 at 07:00:39PM -0400, Jung-uk Kim thus spake:
>> > >Hmm...  It doesn't seem right.
>> > >
>> > >% cat /usr/local/bin/ecj.sh
>> > >#!/bin/sh
>> > >
>> > >/usr/local/openjdk6/bin/javac -classpath
>> > > /usr/local/share/java/classes/ecj.jar $1 %
>> > > /usr/local/bin/ecj.sh -version
>> > >javac 1.6.0_30
>> > >% /usr/local/openjdk6/bin/javac -version
>> > >javac 1.6.0_30
>> > >
>> > >Please note it isn't coming from ecj.jar.
>> >
>> > That is grabbing the version of javac based on the shell script.
>> > I'm not certain if you can get a vesion of the jar with an
>> > argument, or if that argument is even valid.
>> >
>> > >Also, `$1' should be `$*'.
>>
>> I could be wrong, but I thought the preferred version of this was
>> "$@" (as is, including the double quotes).  IIRC using $* doesn't
>> quite work properly if some of your arguments have spaces in them.
>
>Ah, you're right, "$@" is better than $* in this case.

I can change this.
>
>> Instead of %%JAVAC%% I'd suggest %%LOCALBASE%%/bin/javac so that
>> the selection of which JDK to use can be done at run time rather
>> than port install time.
>
>I totally agree with you, too.  However, it should be java.  javac
>cannot "execute" ecj.jar.

I was able to compile with javac, but not with java. Do you have the
arguments you've used to compile with ecj.jar with using "java"
>
>Thanks,
>
>Jung-uk Kim
>

Thanks,
Jason

-- 
Jason Helfman         | FreeBSD Committer
jgh at FreeBSD.org       | http://people.freebsd.org/~jgh