Azureus port skeleton for testing

[Jeremy Faulkner]

On Thu, 2004-10-07 at 13:50, Herve Quiroz wrote:
> First, the Makefile itself:
> 
> - A quick portlint give me the following output:
> 
>     WARN: Makefile: "EXTRACT_ONLY" has to appear earlier.
>     WARN: Makefile: "DISTFILES" has to appear earlier.
>     WARN: Makefile: "EXTRACT_ONLY" has to appear earlier.
>     0 fatal errors and 3 warnings found.

portlint and I have never gotten along well together, until now.

> - It is generally not a good idea to install JAR files in ${PREFIX}/bin.
>   As suggested in [1], a Java application should install its data files
>   (such as its JAR files) in an overriden ${DATADIR} which is set to
>   ${JAVASHAREDIR}/${PORTNAME}.

Ok.

> Second, looking at your shell script in files/, there are some things
> you may improve:
> 
> - Too many paths are hardcoded. You may use %%PREFIX%% for instance and
>   perform some sed magic in 'do-configure' target. Don't forget to
>   differenciate ${PREFIX} (for everything related to the current port)
>   and ${LOCALBASE} (for everything else, such as Eclipse stuff).
> 
> - The same goes for the path of the 'java' executable. You could rather
>   use the same kind of sed magic to replace %%JAVA%% with ${JAVA}.
> 

Yes, I know there are a lot of hard coded values in the script, I even
said as much in my email to the list. The new version of the port that I
just uploaded (10:30 EST Thursday) should be better, and should allow
the use of the motif SWT. I'll test the motif SWT during the weekend.

> That said, this is just a quick review as I don't have enough time ATM.
> If nobody else handles this port by the next days, I will probably
> handle this myself. In such a case, you may send a PR and CC me. We're
> still under ports CVS tree freeze ATM, so there's no hurry here.
> 
> Herve

I'll create the PR when I'm satisfied with the port. I think the
currently available version is Pretty Damn Close To Done (TM).

-- 
Jeremy Faulkner <gldisater at gldis.ca>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-java/attachments/20041007/0f92317d/attachment.bin