jdk14 patches

Munehiro Matsuda haro at kgt.co.jp
Thu Oct 9 02:25:27 PDT 2003


From: Greg Lewis <glewis at eyesbeyond.com>
Date: Wed, 8 Oct 2003 18:51:13 -0600
::Attached is a set of patches for the jdk14 port.  These should fix a number
::of well known bugs, including getting things compiling on -CURRENT.

Hello Greg,

Good work, as always. :-)

But grancing through your patches, I'm not sure I like the
following part, which tries to work around the '_LITTLE_ENDIAN'
problem. This change may hide other errors, that may cause
more trouble in the future.

+--- ../../j2se/make/java/nio/Makefile	15 Feb 2003 14:45:49 -0000	1.4
++++ ../../j2se/make/java/nio/Makefile	24 Aug 2003 05:37:04 -0000
+@@ -131,7 +131,7 @@
+ 
+ # XXXBSD: really need it for BSD ?
+ ifeq ($(PLATFORM), bsd)
+-OTHER_CFLAGS += -Werror
++#OTHER_CFLAGS += -Werror


I use the following patch myself. I don't like my patch, neither. ;-)
But better show errors, than hide them away.

---8<------8<------8<--- patch-zharo-common::Defs-bsd.gmk ---8<------8<----
--- ../../j2se/make/common/Defs-bsd.gmk.org	Wed Oct  8 09:31:35 2003
+++ ../../j2se/make/common/Defs-bsd.gmk	Mon Oct  6 20:33:00 2003
@@ -277,7 +277,13 @@
 CXXFLAGS_DBG	= -g
 
 CPPFLAGS_COMMON = -D$(ARCH) -DARCH='"$(ARCH)"' $(VERSION_DEFINES) \
-		  -D_GNU_SOURCE -D_REENTRANT -D_THREAD_SAFE -D_LITTLE_ENDIAN
+		  -D_GNU_SOURCE -D_REENTRANT -D_THREAD_SAFE
+
+ifeq ($(TRUE_PLATFORM), FreeBSD)
+CPPFLAGS_COMMON += -D_LITTLE_ENDIAN=1234
+else
+CPPFLAGS_COMMON += -D_LITTLE_ENDIAN
+endif
 
 ifeq ($(ARCH_DATA_MODEL), 64)
 CPPFLAGS_COMMON += -D_LP64=1
---8<------8<------8<------8<--- Cut Here ---8<------8<------8<------8<---

Hope this helps,
 Haro
=------------------------------------------------------------------------------
           _ _    Munehiro (haro) Matsuda
 -|- /_\  |_|_|   Internet Solution Dept., Kubota Graphics Technologies Inc.
 /|\ |_|  |_|_|   2-8-8 Shinjuku Shinjuku-ku Tokyo 160-0022, Japan
                  Tel: +81-3-3225-0767  Fax: +81-3-3225-0740
                  Email: haro at kgt.co.jp


More information about the freebsd-java mailing list