misc/174436: [jail] Jails with numbers as names don't work

[Robert Schulze]

The following reply was made to PR kern/174436; it has been noted by GNATS.

From: Robert Schulze <rs at bytecamp.net>
To: Mateusz Guzik <mjguzik at gmail.com>
Cc: bug-followup at FreeBSD.org
Subject: Re: misc/174436: [jail] Jails with numbers as names don't work
Date: Tue, 18 Dec 2012 12:01:43 +0100

 Hi,
 
 Am 18.12.2012 11:18, schrieb Mateusz Guzik:
 > I was reading wrong version of rc.d script. Name is passed with -n switch.
 >
 > Looks like we can get to prison_deref before RACCT is initialized for
 > given prison.
 >
 > Please test the following:
 > diff --git a/sys/kern/kern_jail.c b/sys/kern/kern_jail.c
 > index 1dc43ab..7ca1d72 100644
 > --- a/sys/kern/kern_jail.c
 > +++ b/sys/kern/kern_jail.c
 > @@ -2604,7 +2604,8 @@ prison_deref(struct prison *pr, int flags)
 >                          cpuset_rel(pr->pr_cpuset);
 >                  osd_jail_exit(pr);
 >   #ifdef RACCT
 > -               prison_racct_detach(pr);
 > +               if (pr->pr_prison_racct != NULL)
 > +                       prison_racct_detach(pr);
 >   #endif
 >                  free(pr, M_PRISON);
 >
 
 this fixed the panic, but the jail can still not be started:
 
 # /etc/rc.d/jail onestart 0
 Configuring jails:.
 Starting jails: cannot start jail "0":
 .
 
 with kind regards,
 Robert Schulze