[Bug 203585] update 235959 and 235961 breaks ipv6 layer 4 checksums in ipf

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Jul 12 00:51:42 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203585

--- Comment #4 from commit-hook at freebsd.org ---
A commit references this bug:

Author: cy
Date: Fri Jul 12 00:50:36 UTC 2019
New revision: 349927
URL: https://svnweb.freebsd.org/changeset/base/349927

Log:
  MFC r348987, r348989:

  Resolve IPv6 checksum errors with stateful inspection. According to
  PR/203585 this appears to have been broken by r235959, which predates
  the ipfilter 5.1.2 import into FreeBSD.

  The IPv6 checksum calculation is incorrect. To resolve this we call
  in6_cksum() to do the the heavy lifting for us, through a new function
  ipf_pcksum6(). Should we need to revisit this area again, a DTrace probe
  is added to aid with future debugging.

  Plus whitespace adjustments (r348989).

  PR:           203275, 203585
  Differential Revision:        https://reviews.freebsd.org/D20583

Changes:
_U  stable/10/
  stable/10/sys/contrib/ipfilter/netinet/fil.c
  stable/10/sys/contrib/ipfilter/netinet/ip_fil.h
  stable/10/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c
_U  stable/11/
  stable/11/sys/contrib/ipfilter/netinet/fil.c
  stable/11/sys/contrib/ipfilter/netinet/ip_fil.h
  stable/11/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c
_U  stable/12/
  stable/12/sys/contrib/ipfilter/netinet/fil.c
  stable/12/sys/contrib/ipfilter/netinet/ip_fil.h
  stable/12/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-ipfw mailing list