ipfw: missing action

[Michael Sierchio]

I'm really distressed about the state of ipfw development.  Is there no test
harness?  Rather than becoming more mature and stable, I think it's in the
weeds these days.

- M

On Wed, Mar 24, 2010 at 2:38 PM, Marcin Wisnicki <
mwisnicki+freebsd at gmail.com <mwisnicki%2Bfreebsd at gmail.com>> wrote:

> Another victim of recent MFC:
>
> # ipfw -n add 00100 set 2 allow all from any to any via lo0
> ipfw: missing action
>
> Bug also exists on head.
> Someone should add "write IPFW testsuite" to FreeBSD project ideas ;)
>
> diff -ruN /usr/src/sbin/ipfw/ipfw2.c /home/marcin/p/bugfix/ipfw/ipfw2.c
> --- /usr/src/sbin/ipfw/ipfw2.c  2010-03-24 04:19:34.000000000 +0100
> +++ /home/marcin/p/bugfix/ipfw/ipfw2.c  2010-03-24 22:07:33.000000000 +0100
> @@ -2656,7 +2656,7 @@
>        }
>
>        /* [set N]      -- set number (0..RESVD_SET), optional */
> -       if (av[0] && !av[1] && _substrcmp(*av, "set") == 0) {
> +       if (av[0] && av[1] && _substrcmp(*av, "set") == 0) {
>                int set = strtoul(av[1], NULL, 10);
>                if (set < 0 || set > RESVD_SET)
>                        errx(EX_DATAERR, "illegal set %s", av[1]);
>
> _______________________________________________
> freebsd-ipfw at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw
> To unsubscribe, send any mail to "freebsd-ipfw-unsubscribe at freebsd.org"
>