bin/98349 [Re: cvs commit: src/sbin/ipfw ipfw2.c]

[Max Laier]

On Friday 02 June 2006 07:17, Max Laier wrote:
> mlaier      2006-06-02 05:17:17 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sbin/ipfw            ipfw2.c
>   Log:
>   Print dynamic rules for IPv6 as well.
>
>   PR:             bin/98349
>   Submitted by:   Mark Andrews
>   MFC after:      2 weeks
>
>   Revision  Changes    Path
>   1.90      +15 -5     src/sbin/ipfw/ipfw2.c

It's highly confusing that we have {src,dst}_{ip,port} in host byte order 
while {src,dst}_ip6 are in network byte order.  I think that keeping network 
byte order in the kernel and doing flipping in userland where needed would be 
beneficial.  It should also be possible to unify IPv4 and IPv6 addresses in 
an union, sockaddr_storage or the like.

Anyone looking for a fun project to tackle? ;)

-- 
/"\  Best regards,                      | mlaier at freebsd.org
\ /  Max Laier                          | ICQ #67774661
 X   http://pf4freebsd.love2party.net/  | mlaier at EFnet
/ \  ASCII Ribbon Campaign              | Against HTML Mail and News
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ipfw/attachments/20060602/66e72908/attachment.pgp