i386/111063: ipfw compiliation problem (buildworld)

[Peter Sanchez]

>Number:         111063
>Category:       i386
>Synopsis:       ipfw compiliation problem (buildworld)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-i386
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 31 17:00:10 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Peter Sanchez
>Release:        6.2-Release
>Organization:
>Environment:
FreeBSD foto.ahcabron.com 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Fri Jan 12 10:40:27 UTC 2007     root at dessler.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
This is a new server being setup. The OS was initially installed in January but the machine is being taking live now. I used cvsup9.freebsd.org to cvsup to the latest -STABLE on 3/30/2007 about 9pm PST. During the buildworld process I had compialation errors with /usr/src/sbin/ipfw/ipfw2.c at line 3976. The line shows:

action->len = F_INSN_SIZE(ipfw_insn_pipe);

(same line is also on line 3981)

The error is that ipfw_insn_pipe was undeclared. Sorry, I didn't save the actual make error output, but it was just that the variable was not declared previously. I saw no other instance of ipfw_insn_pipe in the source for ipfw, so I changed the 2 lines to the following:

action->len = F_INSN_SIZE(ipfw_insn);

ipfw_insn appears to be a valid struct variable and is used in other places in the ipfw source. Once I made this change ipfw compiled normally and buildworld was successful. Not sure if this is correct or not, but I don't use ipfw anyways, so I'm happy. Just wanted to report it.
>How-To-Repeat:
Simply cvsup to latest and buildworld
>Fix:
- action->len = F_INSN_SIZE(ipfw_insn_pipe);
+ action->len = F_INSN_SIZE(ipfw_insn);

in sbin/ipfw/ipfw2.c
>Release-Note:
>Audit-Trail:
>Unformatted: