i386/110828: boot0sio never sets port speed

[Thomas Quinot]

>Number:         110828
>Category:       i386
>Synopsis:       boot0sio never sets port speed
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-i386
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 26 00:10:03 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Thomas Quinot
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD melamine.cuivre.fr.eu.org 6.2-STABLE FreeBSD 6.2-STABLE #0: Sun Mar 18 12:49:35 CET 2007 thomas at melamine.cuivre.fr.eu.org:/space/build/obj/space/build/src/RELENG_6/sys/SMP i386


	
>Description:
	A junk value is passed in AX when bioscom is called to set up serial
	port parameters because COMSPEED is treated as an address instead of
	an immediate value. This causes the port parameters not to be set.

>How-To-Repeat:
	
>Fix:

Index: boot0.S
===================================================================
RCS file: /space/mirror/ncvs/src/sys/boot/i386/boot0/boot0.S,v
retrieving revision 1.14.2.1
diff -u -r1.14.2.1 boot0.S
--- boot0.S	31 May 2006 21:32:24 -0000	1.14.2.1
+++ boot0.S	25 Mar 2007 23:56:53 -0000
@@ -96,7 +96,7 @@
 /*
  * Initialize the serial port.  bioscom preserves the driver number in DX.
  */
-		movw COMSPEED,%ax		# defined by Makefile
+		movw $COMSPEED,%ax		# defined by Makefile
 		callw bioscom
 #endif
 /*


>Release-Note:
>Audit-Trail:
>Unformatted: