i386/118572: RealTek 8169S RE device promiscuous mode was Not Active

[kondo]

>Number:         118572
>Category:       i386
>Synopsis:       RealTek 8169S RE device promiscuous mode was Not Active
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-i386
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 12 10:40:02 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     kondo
>Release:        FreeBSD 6.3-PRERELEASE
>Organization:
Technocomputer
>Environment:
reeBSD gw2-osaka.osaka.jcs.co.jp.local 6.3-PRERELEASE FreeBSD 6.3-PRERELEASE #2: Wed Dec 12 14:32:47 JST 2007     root at gw2-osaka.osaka.jcs.co.jp.local:/usr/obj/usr/src/sys/PFCARP  i386
>Description:
I use re0 on carp9.
This dump was failover backup-machine.
tcpdump -i re0
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on re0, link-type EN10MB (Ethernet), capture size 96 bytes
19:23:36.672797 IP 10.101.9.252 > vrrp.mcast.net: VRRPv2, Advertisement, vrid 29, prio 100, authtype none, intvl 1s, length 36
19:23:38.065010 IP 10.101.9.252 > vrrp.mcast.net: VRRPv2, Advertisement, vrid 29, prio 100, authtype none, intvl 1s, length 36

Ping was No problem.
ping 10.101.9.251
PING 10.101.9.251 (10.101.9.251): 56 data bytes
64 bytes from 10.101.9.251: icmp_seq=0 ttl=64 time=0.580 ms
64 bytes from 10.101.9.251: icmp_seq=1 ttl=64 time=0.425 ms

re0: <RealTek 8169S Single-chip Gigabit Ethernet> port 0xd000-0xd0ff mem 0xd04e1000-0xd04e10ff irq 20 at device 0.0 on pci6
miibus2: <MII bus> on re0
rgephy0: <RTL8169S/8110S/8211B media interface> on miibus2
rgephy0:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, 1000baseT, 1000baseT-FDX, auto
re0: Ethernet address: 00:16:01:xx:xx:xx


>How-To-Repeat:
tcpdump -i re0

>Fix:
diff -u /tmp/src/sys/dev/re/if_re.c /usr/src/sys/dev/re/if_re.c
--- /tmp/src/sys/dev/re/if_re.c 2007-12-12 19:35:51.000000000 +0900
+++ /usr/src/sys/dev/re/if_re.c 2007-12-12 19:32:31.000000000 +0900
@@ -636,7 +636,7 @@
        if (ifp->if_flags & IFF_ALLMULTI || ifp->if_flags & IFF_PROMISC) {
                if (ifp->if_flags & IFF_PROMISC)
                        rxfilt |= RL_RXCFG_RX_ALLPHYS;
-               if (ifp->if_flags & IFF_ALLMULTI)
+                       /* if (ifp->if_flags & IFF_ALLMULTI) */
                        rxfilt |= RL_RXCFG_RX_MULTI;
                CSR_WRITE_4(sc, RL_RXCFG, rxfilt);
                CSR_WRITE_4(sc, RL_MAR0, 0xFFFFFFFF);


>Release-Note:
>Audit-Trail:
>Unformatted: