i386/99959: Via Padlock ACE support not detected for via C7 (Esther) processor

[François Charlier]

>Number:         99959
>Category:       i386
>Synopsis:       Via Padlock ACE support not detected for via C7 (Esther) processor
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-i386
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 09 12:30:12 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     François Charlier
>Release:        6.1
>Organization:
>Environment:
FreeBSD loin.ploup.net 6.1-STABLE FreeBSD 6.1-STABLE #0: Sun Jul  9 02:09:00 CEST 2006     naz at loin.ploup.net:/usr/obj/usr/src/sys/DEDIBOX  i386
>Description:
Via Padlock ACE support is not detected vor via Esther (C5J) and maybe Ruth (C5Q) processors. Loading the padlock module returns :
  PADLOCK: No ACE support.

The Via Padlock Programming Guide (http://www.via.com.tw/en/downloads/whitepapers/initiatives/padlock/programming_guide.pdf) specifies on page 5 that "Centaur Extended Features Flags are supported" "if CPUID with EAX = 0xC0000000 returns EAX >= 0xC0000001". However, the file src/sys/crypto/via/padlock.c does the following test in function padlock_init(void) [line 167 in 6.1-STABLE] :
  if (regs[0] == 0xc0000001) {
which is wrong and should be changed to :
  if (regs[0] >= 0xc0000001) {


>How-To-Repeat:
kldload padlock.ko
on a machine with a C7 processor
>Fix:
Follow the programming guide and modify src/sys/crypto/via/padlock.c in function padlock_init(void) [line 167 in 6.1-STABLE] from :
  if (regs[0] == 0xc0000001) {
to :
  if (regs[0] >= 0xc0000001) {

>Release-Note:
>Audit-Trail:
>Unformatted: