citrus/BSD iconv doesn't respect ICONV_SET_DISCARD_ILSEQ flag

[Andrey Chernov]

On 10.04.2017 13:41, Lev Serebryakov wrote:
> On 09.04.2017 16:06, Andrey Chernov wrote:
> 
>> I need to add that our iconv also don't support anything after //
>> forcing ports using GNU iconv:
>>         /*
>>          * Remove anything following a //, as these are options (like
>>          * //ignore, //translate, etc) and we just don't handle them.
>>          * This is for compatibility with software that uses these
>>          * blindly.
>>          */
>> //ignore is analogue of ICONV_SET_DISCARD_ILSEQ on.
>  But later in code:
> 
> handle->cv_shared->ci_discard_ilseq = strcasestr(out, "//IGNORE");
> 
>  So, "//IGNORE" is "supported" (in same way as ICONV_SET_DISCARD_ILSEQ
> is "supported")
> 

I isn't, it just being set/unset without affecting anything. Grep
ci_discard_ilseq through BSD iconv sources.