Committing one ipfw(8) userland patch

Lev Serebryakov lev at FreeBSD.org
Tue Apr 7 12:31:09 UTC 2020


On 07.04.2020 11:28, Andrey V. Elsukov wrote:

>> I have one patch for the ipfw userland tool:
>> https://reviews.freebsd.org/D24234
>>
>> This patch adds the src-ip4/dst-ip4 and src-ipv4/dst-ipv4 aliases for
>> src-ip/dst-ip commands respectively in IPFW.
>>
>> Could someone please commit this patch?
> 
> Can you describe what is the benefit to have all these aliases, when
> after adding the rule you will still see other name. I think this makes
> it more confusing.
 I think, {src|dst}-ip without version should exist only for backward
compatibility and, maybe, produce warnings.

 Why? symmetry & consistency. And equal length of fields in rules for
different versions, too :-)

 Also, there are confusion with me/me4/me6. When `src-ip` is really
`src-ip4`, what does `me` mean? `me4`? or `me4 OR me6`?


-- 
// Lev Serebryakov

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20200407/d5e49f5e/attachment.sig>


More information about the freebsd-hackers mailing list