[CFT] capsicum patches for rtsol(8) and rtsold(8)

[Bjoern A. Zeeb]

On 16 Oct 2018, at 16:53, Mark Johnston wrote:

> On Tue, Oct 16, 2018 at 04:06:43PM +0000, Bjoern A. Zeeb wrote:
>> On 15 Oct 2018, at 19:42, Mark Johnston wrote:
>>
>>> https://people.freebsd.org/~markj/patches/rtsold_capsicum.diff
>>
>> (0) the git rename doesn’t really work when applying the diff with
>> FreeBSD’s patch so the mv has to be done manually
>>
>> (1) the rtsol Makefile also needs cap_syslog and util to link to
>> otherwise rtsold.c has unresolved symbols
>>
>> (2) rtsol seem to have worked when manually invoked;  
>> /etc/resolv.conf
>> was created (I had rm’ed it) and the 3 nameserver lines 
>> re-appeared;
>> sorry can’t test the search string here
>>
>> (3) rtsold crashes:
>
> Thanks.  I made some last-minute changes and forgot to retest, of
> course. :(
>
> I uploaded a new patch which should fix all of these issues - could 
> you
> give it a try?

With the old and new patch:

root at i386-a3-carp:/usr/src/sbin/rtsol # rtsol vtnet0
failed to run script: Invalid argument

Hadn’t noticed that before.


Also on a running system:

root at i386-a3-carp:/ # rm /etc/resolv.conf
root at i386-a3-carp:/ # cat /etc/resolv.conf
cat: /etc/resolv.conf: No such file or directory
root at i386-a3-carp:/ # sh /etc/rc.d/rtsold restart
Stopping rtsold.
Waiting for PIDS: 1047.
Starting rtsold.
root at i386-a3-carp:/ # cat /etc/resolv.conf
cat: /etc/resolv.conf: No such file or directory


After a reboot:

root at i386-a3-carp:~ # ps ax | grep rts
372  -  SCs  0:00.01 /usr/sbin/rtsold -a
375  -  Ss   0:00.01 rtsold: system.syslog (rtsold)
376  -  S    0:00.00 rtsold: rtsold.script (rtsold)
693 u0  R+   0:00.01 grep rts
root at i386-a3-carp:~ # cat /etc/resolv.conf
# Generated by resolvconf
nameserver ..

root at i386-a3-carp:~ # rtsol vtnet0
failed to run script: Invalid argument
root at i386-a3-carp:~ # sh /etc/rc.d/rtsold restart
Stopping rtsold.
Waiting for PIDS: 372.
Starting rtsold.
Oct 16 18:28:33 i386-a3-carp rtsold[734]: <call_script> failed to run 
script: Invalid argument


/bz