Bug 207069 (loader password kills boot)

[David Cross]

From my investigation when I wrote the patch originally the problem is (as I recall, its been awhile) the forth dictionary space is limited so parts are flushed out (that is the only section at the top)  additional dictionaries are then explicitly loaded (the also sections. The load_kernel and load_modules are needed from the support-functions dictionaries

As for why this is now needed here, there was a change made ~2 years ago to defer loading the kernel until the system was just about to boot (after beastie menu vs before). Autoboot assumes that kernel is loaded and will not load for you. Making it load for you conflicts with the menu loading it. So it password is enabled menu and kernel loading doesn’t happen. This reatores that and puts it right before autoboot (which is a C portion of loader)

(Going off of memory from ~2 years ago)

Apologies for naming the patch works for me. This wasn’t just slap it in where it worked, i spent a good amount of time digging into what changed, why, and to maintain the desired flow,

> On May 1, 2018, at 14:22, Kyle Evans <kevans at freebsd.org> wrote:
> 
>> On Tue, May 1, 2018 at 1:17 PM, Warner Losh <imp at bsdimp.com> wrote:
>> 
>> 
>>> On Tue, May 1, 2018 at 12:12 PM, Kyle Evans <kevans at freebsd.org> wrote:
>>> 
>>>> On Tue, May 1, 2018 at 1:07 PM, David Cross <dcrosstech at gmail.com> wrote:
>>>> The aforementioned bug has been open for over 2 years, with attached and
>>>> tested patches. At least one other has commented.
>>>> 
>>>> Could we please have it for 11.2/12.0?
>>> 
>>> Hi,
>>> 
>>> CC'ing Devin, our local Forth-fu-fighter. If it looks ok to Devin, one
>>> of us should go ahead and shuffle this through.
>> 
>> 
>> Yes. I've looked at this code a fair amount, and I don't understand why this
>> is needed and why it would make things work. Since it is a security thing,
>> I'm very reluctant to push it in absent better understanding of why it
>> works.
>> 
> 
> Right, it also confuses me. =)
> 
> When I was implementing this stuff for Lua, autoboot DTRT as long as
> module_path is setup correctly -- this is probably the part that's
> missing since IIRC that's usually done in menu setup (that doesn't
> happen here).
> 
> I'm not sure if this the right way to fix it in Forth-land, though.