bmake: variable modifiers in SysV include

[Pietro Cerutti]

On Mar 28 18 17:13, Simon J. Gerraty wrote:
>Pietro Cerutti <gahr at FreeBSD.org> wrote:
>
>> our make (contrib/bmake) does not currently support variable modifiers
>> in SysV-style "include" directives. See this simple example:
>
>> Apart from parentheses reshuffling, the patch just removes a check
>> that inhibits SysV inclusion if the line being parsed contains a colon
>> (:) character.
>>
>> This has been there since bmake has supported SysV includes [2].
>>
>> Questions:
>>
>> 1. Any ideas why the check is there, and what problem it's preventing?
>> 2. Anybody with src bit would like to approve me committing the fix?
>
>Can you pls fwd your issue to tech-toolchain at netbsd.org (cc me)
>that way whoever it was who added the support for sysV style include
>can comment.

Hi Simon,

I can't reply to Christos' email properly because I'm not subscribed to 
that ML. Anyway, it looks like the original reason for the check on the 
colon doesn't look too sustainable anymore :)

Would you like to commit my fix to NetBSD?

Thanks!

-- 
Pietro Cerutti
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 898 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20180330/038a2393/attachment.sig>