bmake: variable modifiers in SysV include

Pietro Cerutti gahr at
Wed Mar 28 11:58:28 UTC 2018


our make (contrib/bmake) does not currently support variable modifiers 
in SysV-style "include" directives. See this simple example:


% cat Makefile
# Makefile


include $( # ===== THIS =====


FOO=    foo


BAR=    bar


        @echo ${FOO} ${BAR}

% make
make: "/usr/home/gahr/tmp/mk-sysv-include/Makefile" line 5: Need an operator
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/home/gahr/tmp/mk-sysv-include


This patch [1] corrects this problem, and results in the expected

% make
foo bar

Apart from parentheses reshuffling, the patch just removes a check that 
inhibits SysV inclusion if the line being parsed contains a colon (:) 

This has been there since bmake has supported SysV includes [2].


1. Any ideas why the check is there, and what problem it's preventing?
2. Anybody with src bit would like to approve me committing the fix?



Pietro Cerutti
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 898 bytes
Desc: not available
URL: <>

More information about the freebsd-hackers mailing list