Bugzilla converts patch to CRLF line endings?

Oleksandr Tymoshenko gonzo at bluezbox.com
Tue Mar 27 20:27:00 UTC 2018


Stefan Bethke (stb at lassitu.de) wrote:
> Hey,
> 
> I’ve submitted patched for the ports I maintain by copy/pasting the svn diff output into the Bugzilla attachment form for a long time.  The committer working on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226941 noticed that the patch apparently has CRLF line endings, making it hard(er) to apply it properly.
> 
> Working on a Mac with Terminal and Safari, I have not have noticed any such behaviour. When I copy/paste from Bugzilla into Terminal, everything works just fine, so I can do „cd /usr/ports/cat/port; patch -p0“ then paste and ^D.
> 
> When I download the attachment from the „raw“ attachment link (in my example https://bz-attachments.freebsd.org/attachment.cgi?id=191852) with curl or wget, I do get to see CR-LF.
> 
> Where does that happen? And is that a bug or a feature?

I think it's a standard: https://stackoverflow.com/a/14217315
Looks like browser is supposed to convert newlines in input field
to CR LF. I just tried it on our test instance \r\n-s are part
of a request, not added later. Bugzilla doesn't perfomr any
transformation of copy-pasted attachment text and saves it as-is.

-- 
gonzo


More information about the freebsd-hackers mailing list