select call in devd

[Warner Losh]

On Wed, Feb 14, 2018 at 12:13 AM, Eitan Adler <lists at eitanadler.com> wrote:

> Hi all,
>
> select(2) is declared with restrict for the pointers for fd. Can y'all
> confirm this is the correct fix?
>

No. It's not. Select is not declared with restrict parameters. pselect is,
but select is not.

There's no real call to change it.

Warner


> It is only lightly tested (it seems to do its job on my machine)
>
> Index: devd.cc
> ===================================================================
> --- devd.cc (revision 329192)
> +++ devd.cc (working copy)
> @@ -1021,7 +1021,7 @@ event_loop(void)
>   tv.tv_usec = 0;
>   FD_ZERO(&fds);
>   FD_SET(fd, &fds);
> - rv = select(fd + 1, &fds, &fds, &fds, &tv);
> + rv = select(fd + 1, &fds, NULL, NULL, &tv);
>   // No events -> we've processed all pending events
>   if (rv == 0) {
>   devdlog(LOG_DEBUG, "Calling daemon\n");
>
>
> --
> Eitan Adler
>