problem attaching driver at LPC bus

Warner Losh imp at bsdimp.com
Tue Aug 23 15:48:50 UTC 2016


On Tue, Aug 23, 2016 at 9:45 AM, Ravi Pokala <rpokala at mac.com> wrote:
> -----Original Message-----
> From: <wlosh at bsdimp.com> on behalf of Warner Losh <imp at bsdimp.com>
> Date: 2016-08-23, Tuesday at 08:20
> To: Ravi Pokala <rpokala at mac.com>
> Cc: "freebsd-hackers at freebsd.org" <freebsd-hackers at freebsd.org>, <karu.pruun at gmail.com>
> Subject: Re: problem attaching driver at LPC bus
>
> On Tue, Aug 23, 2016 at 9:13 AM, Ravi Pokala <rpokala at mac.com> wrote:
>>> ...
>>>
>>> One thing to note is that I was careful about keeping track of the RIDs. Several of the existing drivers in the tree seem to just use 0 indiscriminately, and it works because they only use one resource.
>>
>> For ISA drivers, RID is just a number, best thought of as an index.
>> So incrementing here like you've done is the right call.
>>
>> Warner
>
> Right, someone (jhb?) explained that to me at the time. My point is that the common practice of just passing in 0 doesn't always DTRT, especially if you're dealing with multiple resources.

And in PCI drivers :) But yes, you're correct. I just wanted to state
simply the ISA policy: They are numbered 0 to N-1.

Warner


More information about the freebsd-hackers mailing list