make buildkernel figure out compiler type..

[Brooks Davis]

On Fri, Jan 24, 2014 at 12:01:42PM -0800, John-Mark Gurney wrote:
> When I was building armeb, I would often specify the correct compiler
> on buildtools/kernel-tools, but then when I went to buildkernel, I
> would forget...  So, I figured out if we just drop COMPILER_TYPE from
> KMAKEENV, the right magic will be executed to figure out which of
> clang/gcc should be used...
> 
> $ svn diff Makefile.inc1 
> Index: Makefile.inc1
> ===================================================================
> --- Makefile.inc1       (revision 260499)
> +++ Makefile.inc1       (working copy)
> @@ -451,7 +451,7 @@ IMAKE_MTREE=        MTREE_CMD="nmtree ${MTREEFLAGS}"
>  .endif
>  
>  # kernel stage
> -KMAKEENV=      ${WMAKEENV}
> +KMAKEENV=      ${WMAKEENV:NCOMPILER_TYPE=*}
>  KMAKE=         ${KMAKEENV} ${MAKE} ${.MAKEFLAGS} ${KERNEL_FLAGS} KERNEL=${INSTKERNNAME}
>  
>  #
> 
> Comments?

If COMPILER_TYPE isn't set then every submake will need to figure out
which compiler is in use.  That's not too expensive for a build without
modules, but is potentially quite expensive with, hence the passing of
COMPILER_TYPE.  I'm not convinced the tradeoff is worth it for a little
edge-case user convenience.

-- Brooks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20140127/f9398e32/attachment.sig>