[PATCH] Add 4K QUIRK for Intel X25-M, MARVELL SD88SA02 and OCZ Agility 2

[Richard Yao]

I neglected to include the CC list on the previous email that I sent, so
here is a reproduction:

I am afraid that is not possible. I extracted the "MARVELL SD88SA02"
entry from Open Solaris. The OCZ Agility 2 entry was provided by another
Gentoo developer using a tool that performed an inquiry query and
extracted the exact 24 bytes in the combined vendor/product
identification fields. The same was done for the X25-M. I actually do
own one of those and could get FreeBSD running on that machine, but
Artem Belevich has already responded with that information.

On 08/13/2013 10:02 PM, Steven Hartland wrote:
> Could you provide the output from camcontrol identify for these
> disks I want to just double check the formatting before commiting as I
> don't have these disks here in labs.
> 
>    Regards
>    Steve
> 
> ----- Original Message ----- From: "Richard Yao" <ryao at gentoo.org>
> To: <hackers at FreeBSD.org>
> Cc: "Richard Yao" <ryao at gentoo.org>; "Eitan Adler" <eadler at FreeBSD.org>
> Sent: Sunday, August 11, 2013 1:12 PM
> Subject: [PATCH] Add 4K QUIRK for Intel X25-M, MARVELL SD88SA02 and OCZ
> Agility 2
> 
> 
>> Signed-off-by: Richard Yao <ryao at gentoo.org>
>> ---
>> sys/cam/ata/ata_da.c   | 24 ++++++++++++++++++++++++
>> sys/cam/scsi/scsi_da.c | 24 ++++++++++++++++++++++++
>> 2 files changed, 48 insertions(+)
>>
>> diff --git a/sys/cam/ata/ata_da.c b/sys/cam/ata/ata_da.c
>> index f201231..b7f293d 100644
>> --- a/sys/cam/ata/ata_da.c
>> +++ b/sys/cam/ata/ata_da.c
>> @@ -349,6 +349,14 @@ static struct ada_quirk_entry ada_quirk_table[] =
>>  },
>>  {
>>  /*
>> + * Intel X25-M Series SSDs
>> + * 4k optimised & trim only works in 4k requests + 4k aligned
>> + */
>> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "INTEL SSDSA2M*", "*" },
>> + /*quirks*/ADA_Q_4K
>> + },
>> + {
>> + /*
>>  * Kingston E100 Series SSDs
>>  * 4k optimised & trim only works in 4k requests + 4k aligned
>>  */
>> @@ -365,6 +373,22 @@ static struct ada_quirk_entry ada_quirk_table[] =
>>  },
>>  {
>>  /*
>> + * Marvell SSD (entry taken from Open Solaris)
>> + * 4k optimised & trim only works in 4k requests + 4k aligned
>> + */
>> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "MARVELL SD88SA02*", "*" },
>> + /*quirks*/ADA_Q_4K
>> + },
>> + {
>> + /*
>> + * OCZ Agility 2 SSDs
>> + * 4k optimised & trim only works in 4k requests + 4k aligned
>> + */
>> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "OCZ-AGILITY2*", "*" },
>> + /*quirks*/ADA_Q_4K
>> + },
>> + {
>> + /*
>>  * OCZ Agility 3 SSDs
>>  * 4k optimised & trim only works in 4k requests + 4k aligned
>>  */
>> diff --git a/sys/cam/scsi/scsi_da.c b/sys/cam/scsi/scsi_da.c
>> index 617afbd..df895be 100644
>> --- a/sys/cam/scsi/scsi_da.c
>> +++ b/sys/cam/scsi/scsi_da.c
>> @@ -1008,6 +1008,14 @@ static struct da_quirk_entry da_quirk_table[] =
>>  },
>>  {
>>  /*
>> + * Intel X25-M Series SSDs
>> + * 4k optimised & trim only works in 4k requests + 4k aligned
>> + */
>> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "INTEL SSDSA2M*", "*" },
>> + /*quirks*/ADA_Q_4K
>> + },
>> + {
>> + /*
>>  * Kingston E100 Series SSDs
>>  * 4k optimised & trim only works in 4k requests + 4k aligned
>>  */
>> @@ -1024,6 +1032,22 @@ static struct da_quirk_entry da_quirk_table[] =
>>  },
>>  {
>>  /*
>> + * Marvell SSD (entry taken from Open Solaris)
>> + * 4k optimised & trim only works in 4k requests + 4k aligned
>> + */
>> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "MARVELL SD88SA02*", "*" },
>> + /*quirks*/ADA_Q_4K
>> + },
>> + {
>> + /*
>> + * OCZ Agility 2 SSDs
>> + * 4k optimised & trim only works in 4k requests + 4k aligned
>> + */
>> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "OCZ-AGILITY2*", "*" },
>> + /*quirks*/ADA_Q_4K
>> + },
>> + {
>> + /*
>>  * OCZ Agility 3 SSDs
>>  * 4k optimised & trim only works in 4k requests + 4k aligned
>>  */
>> -- 
>> 1.8.1.5
>>
>> _______________________________________________
>> freebsd-hackers at freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
>> To unsubscribe, send any mail to
>> "freebsd-hackers-unsubscribe at freebsd.org"
>>
> 
> ================================================
> This e.mail is private and confidential between Multiplay (UK) Ltd. and
> the person or entity to whom it is addressed. In the event of
> misdirection, the recipient is prohibited from using, copying, printing
> or otherwise disseminating it or any information contained in it.
> In the event of misdirection, illegible or incomplete transmission
> please telephone +44 845 868 1337
> or return the E.mail to postmaster at multiplay.co.uk.
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20130814/6bf494f1/attachment.sig>