[CFT/RFC]: refactor bsd.prog.mk to understand multiple programs instead of a singular program

Garrett Cooper yanegomi at gmail.com
Fri Oct 26 20:07:46 UTC 2012


On Fri, Oct 26, 2012 at 12:54 PM, Simon J. Gerraty <sjg at juniper.net> wrote:
>
> On Fri, 26 Oct 2012 12:27:35 -0700, Garrett Cooper writes:
>>There are some basic examples, but they're in my p4 branch and
>>unfortunately they depend on atf.test.mk/bsd.test.mk/bsd.progs.mk
>
> Speaking of which.  I notice there is now a bsd.progs.mk in head, which
> bears little relationship to the one I was talking about (from
> devel/bmake).  Is this bsd.progs.mk essentially your port of netbsd's
> bsd.prog.mk it seems much more complex than should be necessary (my
> progs.mk is 75 lines vs 350 for the one in head).

Yup. I was a bit surprised it was committed, but there might have been
some confusion over what all was going to go in with the ATF port.

> Would you be awfully upset if I replace it with the simpler one?

    Nah. Feel free to nuke it and remove it from the build once you
get progs.mk in proper shape; I'm more concerned about completing the
atf.test.mk/bsd.test.mk snippets because once those are committed I
can get the test example code and the integration test patches
reviewed and committed.
Thanks!
-Garrett


More information about the freebsd-hackers mailing list